Nginx config and upload woes

billcolumbia

I'm trying out IndigoStack with Craft CMS. Feels nice to have fast dev work on a Mac again.

Overall everything installed and works. I ran into my first real issue trying to upload files in the control panel of Craft. As far as I can tell, it's related to Nginx.

The error on upload: 413 Request Entity Too Large
The file in question is 2MB.
PHP is configured as:

memory_limit = 512M
max_execution_time = 180
upload_max_filesize = 10M
post_max_size = 15M

I've updated the config for nginx by following some guidance here in the community and the advanced configuration docs. My process was to find the stacks random ID folders in .indigo/stacks/####/nginx_####/conf/nginx.conf, copy it, modify it to have client_max_body_size = 10M, and then move it into documents/Indigo/stack.indigostack/nginx_####. When I use localhost with my port, no problems it now works, so it looks like my stack is updated. But when I'm using the domain.test with system stack's nginx reverse proxy, I lose that config setting. Should I try to override the system stack or am I missing something with order of operations here?

My stack is Nginx, PHP 8.1, and MySQL 8. Configuring PHP with the overrides textarea in the app was a breeze. Would be nice to have something like that for nginx, and the system stack nginx, but I can see why it would be trickier with nginx's contexts closures.

Indigo

Hi Bill & welcome to the forums 🙂 I'll respond fully later but for now have a few quick thoughts:

at a glance at your notes above, it looks like you might have modified the config of the nginx service in your stack rather than the system stack's separate nginx instance, which is what provides the reverse proxy. You'll find the latter at ~/.indigo/stacks/system-stack/nginx_reverse_proxy (or right-click it in the System stack in the UI)
I think the default config for the System stack's nginx reverse proxy is the root cause here, and I am hoping to reconfigure it so it is less likely to be the bottleneck in future
as per your localhost-with-port, you can also use the custom-domain-with-port, both of which will bypass the nginx reverse proxy entirely. This might be a way to get up and running in the interim if needed.
the intention is definitely to implement a similar override GUI in all services where it makes sense, similar to the one currently there for PHP. I'd like to polish the PHP one just a little first, so it's kind-of proof-of-concept thus far, although it does seem to have been doing the job quite nicely 🙂

billcolumbia

Indigo as per your localhost-with-port, you can also use the custom-domain-with-port, both of which will bypass the nginx reverse proxy entirely. This might be a way to get up and running in the interim if needed.

Good to know!

Indigo the intention is definitely to implement a similar override GUI in all services where it makes sense, similar to the one currently there for PHP. I'd like to polish the PHP one just a little first, so it's kind-of proof-of-concept thus far, although it does seem to have been doing the job quite nicely 🙂

That sounds awesome!

Indigo I have a question for you if you don't mind; I guess without configuring client_max_body_size in both the Nginx reverse proxy config AND your stack's Nginx config, the default will take effect (which is 1M). I lean towards only configuring it as client_max_body_size: 0; in the reverse proxy side, meaning you would still have to explicitly configure Nginx sites to allow larger.

I'm not 100% sure. If there is a UI eventually for configuring nginx and I just have to add an override there, that's probably easy enough. If I would have to override the system stack outside of a UI with a conf file and then use the UI in my stack that might be kind of awkward, but also not a really big ask if it's obvious or documented. It's nice when things 'just work' but it's not a deal breaker for me — every code base can have its quirks anyway.

I'll poke around a bit more with all this information (thank you!) and I'll keep an eye out for that next release.

Indigo

OK, in the next Indigo release I've added the following to the reverse proxy config template:

client_max_body_size 0;

This tells Nginx not to check the client request body size at all (and thus not limit it). You can find this template at ~/.indigo/stacks/system-stack/nginx_reverse_proxy/templates/reverseproxy.http.conf (nb you can't edit it there though!)

Hopefully this will resolve the issue; thanks for your help identifying it.

To answer your question specifically:

Should I try to override the system stack

Yes 🙂

I have a question for you if you don't mind; I guess without configuring client_max_body_size in both the Nginx reverse proxy config AND your stack's Nginx config, the default will take effect (which is 1M). I lean towards only configuring it as client_max_body_size: 0; in the reverse proxy side, meaning you would still have to explicitly configure Nginx sites to allow larger.

With the upcoming Nginx config override UI that should be done pretty easily. However this feels like a pretty common requirement, so I'm interested to hear if you would have preferred it to "just work" out of the box, even if doing so makes some pretty baseless assumptions about your needs.