Rebuilding custom stack causes System stack to hang on "Preparing"

filliph

I added a slew of older PHP versions to my stack, as one of the things that caused me to switch to Docker was the ability to quickly switch between PHP versions for testing purposes. Since I need to make changes to the config files, I highlighted my custom stack and chose "Stack -> Rebuild" from the menu bar, thinking it would only need to rebuild my personal stack.

The stack rebuilt fairly quickly, but nothing else would work because the System stack wasn't running. It was stuck on the "Preparing" screen. Quitting Indigo and relaunching it did not require another rebuild of the System stack, and everything appears to be working.

Is this intended behaviour and I was just impatient, or is it a bug that the system stack appears to rebuild whenever a custom stack is also rebuilt?

Indigo

Oh, also...

filliph Since I need to make changes to the config files, I highlighted my custom stack and chose "Stack -> Rebuild" from the menu bar

Can I just confirm you've got beta 10? It has the new PHP config UI and should take care of stack rebuilds automatically when you save your changes.

Indigo

The system stack does rebuild any time activity occurs on another stack, as the required nginx reverse proxy configuration might be affected, same for the required SSL certificates which the system stack also provides. Indeed when a stack rebuilds it also has the chance to directly modify the system stack's config, although this is undocumented as it comes with caveats. So for a few reasons it does have to restart.

I haven't personally been aware of the issue you've described; perhaps I've been willing to wait longer for the system stack to rebuild as I knew what is was doing & why? As part of my new-release QA I create and start a stack with ALL the available services (including every PHP service Indigo provides) and that test passes.

Could you perhaps try your test once again and leave the system stack to rebuild for a bit longer? I can't see why it should take very long though.

filliph

Okay, so this might have been my own impatience 😅 I timed the rebuild, and it took about 2 minutes.

I think for some reason I believed that just making changes to the PHP config would not cause the System stack to rebuild, but thinking about it, it would be next to impossible to account for all the cases where changes do or don't need a System rebuild.

EDIT: I do indeed have Beta 10 just to be clear 😃

filliph

Okay, I was able to replicate it definitely being stuck, it's been going for about 6 minutes now.

Steps:

With the "System" stack & custom stack running, make a change to PHP in the new config UI
When offered, Stop the stack -> The "System" stack will still be running at this point
Finish making the changes (I made changes to all my PHP versions)
Attempt to start the stack -> you'll get the "Port in use" error -> the "System" stack will now shut down
Wait for a minute or so, then attempt to start the stack again -> the "System" stack will now be "Preparing" forever

A full quit of the app (Cmd-Q) and relaunch -> everything is working 100% again.

Indigo

AH, I think you are seeing this dialog, am I right?

That dialog is actually intended to alert you when an external change has been made to the config (for example you directly edited a config file in a text editor, or pulled in from GIT resulting in modified files inside your stack config).

Since in your case it was actually Indigo that instigated the filesystem-level change, you should not be seeing this alert.

However, by following your steps above, I was indeed sometimes able to replicate this. I have a feeling this identifies not one but three separate bugs, all conspiring against you in this scenario lol. Nasty!

I will dig into it. This won't be fun to fix, but if I'm right it will address the two existing intermittent-but-significant bugs I am aware of in Indigo. Thanks for the report!

filliph

Indigo That is indeed the dialog I'm seeing, glad you were able to replicate it 😃

Indigo

This issue should be resolved in beta 11 which has just been released. Let me know how you go!